-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development Server Support #29
Conversation
…o avoid using symlinks
add serve macro for local development
makes serving work
Hugo serve support
…upports generated files
Thanks @platinummonkey I'll try this out! |
Some good changes in this, but the development server appears to reload on changes to files in the output tree. I don't see an easy way to propagate changes back to the source tree... Was it intended? An alternative approach would be to use |
That's the intent and the workflow I use |
So then if I understand correctly, using the hugo server here is not to facilitate hot regeneration of outputs, but rather just as a 'hugo-aware' webserver that gets restarted every time ibazel recompiles? |
correct, I'll be looking at another iteration where I can hint to ibazel when the runfiles for the hugo generation change explicitly to orchestrate the hot reloading steps |
OK, I'll have another look using ibazel. Documentation for the PR should be updated to suggest this workflow. |
This PR is really useful for me. I appreciated your work! f110@a263d59 |
Sounds like we should put a little more effort into getting this merged. @platinummonkey what is your status on this? Any other changes planned? Do you want to apply @f110 patch? |
@f110 's patch is included now 👍 |
also getting new files added even with ibazel has this issue: bazelbuild/bazel-watcher#135 so unfortunately this is about as far as we could take it without pushing this issue upstream for add/remove of files. It does detect runfile files that are modified. |
I don't use ibazel, so I'm not sure if this is out of line for this PR, but I've submitted another PR that allows the use of local theme files, instead of pulling from github, should anyone be interested in merging that with this PR (assuming it's in line with 'development server support'). My workflow is using hugo itself for local development, then having bazel build everything using the same files I've used for local development. This does mean you need to check the theme files into the running bazel, but I think it makes it slightly more deterministic in the long run. |
happy to include it :) will update this PR by end-of-day |
@ryanrf-ac included now 👍 |
LGTM, thanks @platinummonkey, @f110, @ryanrf-ac. |
This PR adds a few features
bzl run