Ironic overcloud hypervisor deployment #1089
Conversation
assumptionsandg
changed the title
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
from
e2e2213 to
e24e4ff
Compare
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
from
e24e4ff to
0493247
Compare
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
from
c01bda2 to
1218ec8
Compare
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
2 times, most recently
from
d02d07d to
7598716
Compare
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
2 times, most recently
from
ed6155e to
e850079
Compare
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
from
e850079 to
d7e920a
Compare
|
@assumptionsandg remember to mark conversations as resolved when you've completed them! Makes it much easier for reviewers to know when to re-review. Is this still a draft? Who do you need a review from to get it merged? |
It's still WIP on the client side of things, hence leaving it as a draft here. We could merge what's here now and interate/fix things as the client work progresses if what's here will be useful to people. |
I'd be happy with it as long as you add a big warning at the top saying the docs are still WIP. Something is better than nothing |
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
from
72cf9c8 to
eb82723
Compare
assumptionsandg
changed the title
assumptionsandg
force-pushed
the
baremetal-hypervisor
branch
from
c484916 to
7f42dee
Compare
|
@assumptionsandg you need to tag people for re-review when you make changes. This has been sat around for two months and I don't think anyone has looked at it |
|
|
||
| - name: Set baremetal node JSON variable | ||
| ansible.builtin.set_fact: | ||
| node_show_json: "{{ node_show.stdout | to_json | from_json }}" |
There was a problem hiding this comment.
| to_json | from_json is a bit weird, and the name of the variable doesn't really fit.
You're taking a string, which is JSON, then converting it to a nice ansible dict var, so "node_show_json" isn't actually json
Also, is it actually used? Can it just be deleted?
|
|
||
| - name: Set baremetal node JSON variable | ||
| ansible.builtin.set_fact: | ||
| node_show_json: "{{ node_show.stdout | to_json | from_json }}" |
There was a problem hiding this comment.
see previous comments on to & from json
| - name: Slurp network allocations | ||
| ansible.builtin.slurp: | ||
| path: "{{ network_allocation_path }}" | ||
| register: net_alc | ||
|
|
||
| - name: Read network allocations | ||
| ansible.builtin.set_fact: | ||
| net_alc_yaml: "{{ net_alc['content'] | b64decode | from_yaml }}" | ||
|
|
||
| - name: Write node IP address to allocations | ||
| ansible.builtin.set_fact: | ||
| new_net_alc: "{{ net_alc_yaml | combine(new_ips, recursive=True) }}" | ||
| vars: | ||
| new_ips: "{ '{{ admin_oc_net_name }}_ips': { '{{ inventory_hostname }}': '{{ ansible_host }}' } }" |
There was a problem hiding this comment.
The net IPs are dictionary vars you have access to right? I don't think you need to slurp them in from a file
Co-authored-by: Alex-Welsh <[email protected]>
Alex-Welsh
added
documentation
|
@assumptionsandg let me know when this is ready for a re-review |
…ayobe-config into baremetal-hypervisor
assumptionsandg
changed the base branch from
stackhpc/2023.1
to
stackhpc/2024.1
assumptionsandg
added
Caracal
Deployment playbook for baremetal instances to be used as hypervisors.
TODO: Documentation refactoring (separate everything prior to hypervisors?)