-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix rabbitmq builds after move to Cloudsmith mirror #1301
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnasiadka
reviewed
Sep 25, 2024
Alex-Welsh
reviewed
Sep 25, 2024
f935edb
to
9252682
Compare
mnasiadka
previously approved these changes
Sep 26, 2024
9252682
to
3dd00cf
Compare
Alex-Welsh
approved these changes
Sep 26, 2024
bbezak
added a commit
that referenced
this pull request
Sep 26, 2024
* Add sed for multiline baseurl in yum repos * use new Rabbitmq Cloudsmith repos * use rabbitmq built from Cloudsmith repo
bbezak
added a commit
that referenced
this pull request
Sep 26, 2024
* Add sed for multiline baseurl in yum repos * use new Rabbitmq Cloudsmith repos * use rabbitmq built from Cloudsmith repo
bbezak
added a commit
that referenced
this pull request
Sep 27, 2024
* Add sed for multiline baseurl in yum repos * use new Rabbitmq Cloudsmith repos * use rabbitmq built from Cloudsmith repo
bbezak
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rabbitmq switched to Cloudsmith repos [1] [2]. Upstream moved as well [3].
Sed which alters repositories during kolla build was not taking into account two lined baseurl.
[1] https://www.rabbitmq.com/blog/2024/08/11/package-repository-updates#packagecloud-will-be-discontinued-on-aug-18th-2024
[2] https://www.rabbitmq.com/blog/2024/08/11/package-repository-updates#mirrors-now-use-rabbitmqcom-domains
[3] https://review.opendev.org/c/openstack/kolla/+/929302
Depends-On: stackhpc/stackhpc-release-train#338