Use Caracal's Magnum #1432
Open
Use Caracal's Magnum #1432
+12
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cityofships
added
Caracal
|
Perhaps should be merged without waiting for CI - Magnum's not tested. |
mnasiadka
previously approved these changes
Dec 23, 2024
cityofships
force-pushed
the
unpin_magnum
branch
from
7073a06 to
66d7a73
Compare
mnasiadka
requested changes
Jan 3, 2025
Upstream Kolla installs magnum-cluster-api by default. Magnum is likely to pick up that driver, so exclude it from the install list and avoid explicitly disabling it in the config.
cityofships
force-pushed
the
unpin_magnum
branch
from
25cc073 to
abe85b8
Compare
|
FWIW unpinning the driver version here feels wrong to me. Since we're not 100% in control of upstream driver releases, we could in theory be broken if other upstream Magnum core reviewers start becoming more active in the driver lifecycle and publishing releases themselves. Maybe we could pin to minor version so that we still get automatic patch releases when rebuilding containers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
magnum-cluster-apidriver.To be merged after #1430.