forked from angular/angularfire
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from angular:master #128
Open
pull
wants to merge
121
commits into
stackriot:master
Choose a base branch
from
angular:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support Firebase v9 * New API that Zone wraps Firebase JS SDK and rxfire * AngularFire v6 API lives on at `@angular/fire/compat/*` * Drop Angular versions less than 12 * Require Ivy
DocumentSnapshot rather than DocumentChange
Typo in deleteToken -> deleteMyToken Co-authored-by: James Daniels <[email protected]>
### Bug fixes * **messaging:** `onMessage` will no longer destablize the Angular Zone * **core:** Injected Classes now have a better fallback pattern for finding defaults, [#2909](#2909) allowing use of emulators and other config options as expected * **schematic:** upgrade schematic will no longer rewrite `.ts` files outside of your project root, [#2907](#2907) ### Misc * **changelog(7.0.0):** break notice for `compat/auth#useEmulator` * **changelog(7.0.0):** feature of `compat/storage#useEmulator` * **changelog(7.0.1):** Added entry * **sample(modular):** Adding `connectEmulator` examples * **sample(compat):** Cleaned up the service worker registration * **functions:** defensively load auth first, if provided * **storage:** defensively load auth first, if provided * **compat/firestore:** clean up how auth is initialized * **compat/database:** clean up how auth is initialized
"FirebaseDeploySchema" schema is using the keyword "id" which its support is deprecated. Now using "$id" for schema ID. Co-authored-by: James Daniels <[email protected]>
Fix for `/compat` missing from firebase import
* Deploy server default is `bundleDependencies: true`, correct this when generating the functions package.json * `onMessage` callback should fire in the ng zone * Auth was wrapping exports it wasn't suppose to * Don't fail the deploy if there isn't an `index.html` file * Lazifying the sample * Cleaning up user-agent reporting * Marking the samples as autogenerated, to reduce noise * Committing the firebase/rxfire/base.ts files for easier readability * Version and changelog entry * Test cleanup and get storage emulator working
Typo, intrested => interested Co-authored-by: James Daniels <[email protected]>
…2922) * Fix the build process in Windows * Add contribute tests * Add firebase-tools as a matrix in the Node tests * Test Node in Windows and MacOS too Co-authored-by: Manuel Bojato <[email protected]>
* Splitting out the samples more * Add sample callouts * Small README changes
* Adding `@angular/fire/app-check` * Right now AppCheck doesn't "allow" you to set the debug token global right before initialization as it's inspected as a side-effect. I devised a hack that wins the race. Downside here is that Angular hasn't been initialized yet, so in order to tell if Angular is in devmode I'm looking up global variables, which are subject to behavior changes. Request has been submitted to the JS SDK team.. * Flushing out the samples a bit more, added appcheck * Changing the tsconfig path resolution so it doesn't have to be exhaustive
Co-authored-by: James Daniels <[email protected]>
* Increase the accuracy of performance marks, by leaning on Zone's start marker * Add automatic transfer state support to the getDownloadURL pipe * Storage.child type fix
Co-authored-by: Tomek Sułkowski <[email protected]>
* `findModuleFromOptions` wasn't working well when SSR was added to the mix, drop * shell out the logged in user(s) * fixed Cloud Functions dependencies all being dev * added `file-loader` dep so the Firestore loaders work out of box
* Make ng-add work with standalone mode * Add simple AppCheck feature addition * Cleanup
* Bump deps * Simplify ng-add a bit * Mark v17 peer * Mark firebase-tools v13 peer * Fix for the Firebase CLI not being logged in, should test this more * Fix for firebase.login.use failing if the user isn't changed * Fix for firebase login add
* Bump firebase, add auth#revokeAccessToken * Add development and production build/serve targets, default to development for emulators * Region select only when universal or ssr
Fixed the link for Getting started with Firebase Authentication
Replaced missing semicolon in Step 4 code block
Type cast collectionData as it was producing an error without it
* Cast collectionData to avoid TS errors Using the current code example, I am getting an error message Typescript error message like: ``` Type 'Observable<(DocumentData | (DocumentData & { .... }))[]>' is not assignable to type 'Observable<Item[]>'. ``` This change also makes this code example more consistent with the current example in [firestore.md](https://github.com/angular/angularfire/blob/5793d6f3a15aa61660af75ab361c534cde9b73df/docs/firestore.md?plain=1#L91) * accept reviewer's suggestion --------- Co-authored-by: James Daniels <[email protected]>
Co-authored-by: James Daniels <[email protected]>
Co-authored-by: GJLMoTea <[email protected]>
* Update emulators.md Added emulator startup information and clarified the environment.useEmulators. Updated the localhost address * Update emulators.md minor update to providers path --------- Co-authored-by: starimploie <[email protected]>
* Update messaging.md * Update messaging.md --------- Co-authored-by: James Daniels <[email protected]>
* feat: provide real standalone providers usage before `importProvidersFrom(provideFirebaseApp(() => initializeApp(...)))` usage now `provideFirebaseApp(() => initializeApp(...))` * test: fixed failed tests * fix: update the missed lite.module.ts
* Standlone DI in the docs * Drop realtime from all the doc breadcrumbs
* There's no RC for `@angular-eslint` drop for now * Bump versions * `TransferState` moved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )