[pull] master from shakacode:master #128
Open
+14,952
−11,012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
* Default install includes sample configuration including SSR with HMR * Supports Rails 7
* add support diff versions of React's render API in React 18, the API for rendering and hydrating elements is updated. This updates the syntax to support both syntaxes so that users of both APIs can still work with the same interface. * move files to reusables so that they can work for ReactOnRails * use ReactDOM.version to determine API for rendering and hydrating
…oduction_command present? (#1402) Update logic on what build command to use in assets:precompile to be based on whether or not config.build_production_command is defined.
* check for the method before calling it
Or else bundler hangs And update spec/dummy
* platform lock for github actions
* Cherry-pick commits from #1215 * Add ReScript dependencies and configuration * Remove Reason file, Replace Reason occurrences by ReScript * Add ReScript component, update yarn.lock at spec/dummy/ Create file to import compiled ReScript components * Add rake task to build ReScript when running rake assets:precompile * Add JavaScript dependency required to build for production * Run prettier and add *.bs.js files to .prettierignore * Add return at the end of the line package.json * Bump prettier, concurrently and prettier-eslint-cli add files to .prettierignore * Update bsconfig.json
* add rendering_props_extension config option
* Update issue templates * Update bug_report.md
* Update spec/react_on_rails/utils_spec.rb
Support shakapacker 8.0.0 package.json - update shakapacker to v8 + add "packageManager" Co-authored-by: Judah Meek
* update actions/cache@v3 to v4 * update actions/setup-node@v3 to v4 * update actions/upload-artifact@v3 to v4 * update changelog * ensure unique artifact name * update actions/cache/save from v3 to v4
* feat: use `package_json` * fixed shakapacker detection during the installation generator work * fixed tests, updated changelog * added package_json to dev dependencies * fixed webpacker example * linted webpacker spec * removed usless import
* should force load react-components which send over turbo-stream * fix navigation error in spec
* Include type-check in CI * Clean up some TypeScript problems * Fix Store/StoreGenerator confusion * Update TypeScript * Add comment --------- Co-authored-by: Alexey Romanov <[email protected]>
* refactor serverRenderReactComponent * add stream package to the dummy app to fix the build problem * improve naming and organization * don't install stream package * add a comment about building console replay before awaiting promise * make a comment clearer * add a comment * move some comments to another place * make createResultObject takes renderState object
Console replay script generation now awaits the render request promise before generating, allowing it to capture console logs from asynchronous operations. The feature of replaying async console logs is implemented in node-renderer in this PR shakacode/react_on_rails_pro#440 * add support for console replay of console logs happen in async operations get console replay messages after promise resolves or rejects use isPromise to check if the result is a promise make consoleReplay function accept the list of logs to be added to the script make consoleHistory argument of consoleReplay optional add comments add comments update comment remove FlowFixMe comment * call clear console history from the generated render code * Revert "call clear console history from the generated render code" This reverts commit 2697ef7. * add comment about clearing console history
* tmp * add support for streaming rendered component using renderToPipeableStream * put ROR scripts after the first rendered chunk * remove log statements * add stream_react_component_async helper function * add helper function to render a whole view * fix failing jest tests * linting * linting * remove redundant new line when context is not prepended * rename stream_react_component_async to stream_react_component * fix error caused by process on browser * remove new line appended to the page when has no rails context * fix the problem of not updating the first streaming chunk * rename stream_react_component_internal to internal_stream_react_component * add unit tests for rails_context_if_not_already_rendered * remove :focus tag from rails_context_if_not_already_rendered spec * make render function returns Readable stream instead of PassThrough * use validateComponent function instead of manually validating it * linting * add some comments * don't return extra null at he end of the stream * update CHANGELOG.md * update docs * update docs
* pass console messages from server to client and replay them * linting * add some comments and remove unneeded calls * fix syntax error * tiny changes * update CHANGELOG.md
* handle errors happen during streaming components * remove debugging statements * linting * emit errors when an error happen and refactor * add unit tests for streamServerRenderedReactComponent * linting * make requested changes * make a condition simpler Co-authored-by: Alexey Romanov <[email protected]> * fix variable name Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * tiny changes * linting * update CHANGELOG.md * rename ensureError function to convertToError * update CHANELOG.md * update CHANELOG.md * update CHANELOG.md --------- Co-authored-by: Alexey Romanov <[email protected]> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
* check both root & client packages * add logging methods instead of changing raise methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )