Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bpf): fix rss_stat being an array and not a struct #78

Merged
merged 4 commits into from
Jun 6, 2024

Conversation

Molter73
Copy link
Contributor

@Molter73 Molter73 commented Jun 3, 2024

This error was originally fixed upstream by adding a full check at source configuration time, this is incompatible with our way of building drivers, so we are skipping that and directly making the check we need explicit. It would be a big deal, but with eBPF deprecation and full removal in the horizon, I think this is an acceptable tradeoff.

Molter73 added 3 commits June 3, 2024 12:09
This patch was extracted from this upstream commit:
falcosecurity/libs@6ff3167

Because we are not backporting the full feature added by the original
PR, this is a smaller patch.
@Molter73 Molter73 force-pushed the mauro/backport-rss-stat-fix branch from c6f636a to 7e49041 Compare June 3, 2024 12:16
Copy link
Collaborator

@Stringy Stringy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's always rss_stat... always.

LGTM!

@Molter73 Molter73 merged commit 8cdcdda into module-version-2.9 Jun 6, 2024
@Andreagit97
Copy link
Contributor

It would be a big deal, but with eBPF deprecation and full removal in the horizon, I think this is an acceptable tradeoff.

Hey folks! Sorry for the random comment, but as if it were a sign of destiny, this PR appeared on my GitHub homepage 😂. If i can ask it, are you planning to deprecate the legacy eBPF probe in StackRox or are you talking about a future deprecation in upstream libs? I ask this just to understand the current adoption of the legacy ebpf probe

@Molter73
Copy link
Contributor Author

Molter73 commented Jun 6, 2024

It would be a big deal, but with eBPF deprecation and full removal in the horizon, I think this is an acceptable tradeoff.

Hey folks! Sorry for the random comment, but as if it were a sign of destiny, this PR appeared on my GitHub homepage 😂. If i can ask it, are you planning to deprecate the legacy eBPF probe in StackRox or are you talking about a future deprecation in upstream libs? I ask this just to understand the current adoption of the legacy ebpf probe

Hey Andrea! We are deprecating the eBPF probe for StackRox, we've already stopped using the kernel module a couple releases ago and we hope we can go full CORE BPF in the near future. We don't have any plans to push for upstream deprecation of any drivers though.

@Andreagit97
Copy link
Contributor

Thank you for the quick answer @Molter73!

we hope we can go full CORE BPF in the near future

❤️ 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants