Stricter Linter

[CAGS295]

Summary of Changes

• Lint with all features enabled and all compilation targets, including tests.
• Use nightly for the linter to catch more patterns.
• Change GHA job dependencies to save GHA runtime.

Testing

Risks

Nothing I can think of.

How were these changes tested?

Manual GH Action runs.

What future testing should occur?

None

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[codecov]

Codecov Report

Merging #201 (ef3430b) into main (e78c1d2) will increase coverage by 0.37%.
Report is 7 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #201      +/-   ##
==========================================
+ Coverage   38.27%   38.65%   +0.37%     
==========================================
  Files          44       44              
  Lines        5029     5052      +23     
  Branches       28       23       -5     
==========================================
+ Hits         1925     1953      +28     
+ Misses       3102     3097       -5     
  Partials        2        2              

Flag	Coverage Δ
unittests	89.07% <ø> (+4.35%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
romeo/src/stacks_client.rs	0.00% <ø> (ø)
sbtc-core/src/operations/op_return/deposit.rs	61.83% <100.00%> (-0.44%)	⬇️
stacks-core/src/c32.rs	95.88% <100.00%> (ø)
stacks-core/src/crypto/sha256.rs	78.72% <100.00%> (ø)
stacks-core/src/uint.rs	83.06% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[AshtonStephens]

Looks good, yeah this linter is better.

Is any of the code altered here not tested?

[CAGS295]

Looks good, yeah this linter is better.

Is any of the code altered here not tested?

No.

[friedger]

LGTM