Only use btc tx once

[friedger]

Summary of Changes

This PR

• changes the asset contract so that mints and burns with the same btc tx will fail when used more than once
• fixes [sBTC DR] binary can use the same tx several times #116

Testing

Risks

Engine might not handle failed mints and burns correctly.

Users might think that the contract verifies all of the content of the text. It does not, the contract only verifies that the btc tx was not yet used for minting or burning.

How were these changes tested?

manual in devenv

What future testing should occur?

Automated integration test

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules

[codecov]

Codecov Report

Merging #206 (dfda661) into main (e78c1d2) will increase coverage by 0.15%.
Report is 4 commits behind head on main.
The diff coverage is 70.96%.

@@            Coverage Diff             @@
##             main     #206      +/-   ##
==========================================
+ Coverage   38.27%   38.42%   +0.15%     
==========================================
  Files          44       44              
  Lines        5029     5051      +22     
  Branches       28       38      +10     
==========================================
+ Hits         1925     1941      +16     
- Misses       3102     3109       +7     
+ Partials        2        1       -1     

Flag	Coverage Δ
unittests	83.24% <70.96%> (-1.48%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
romeo/asset-contract/contracts/asset.clar	100.00% <100.00%> (+6.06%)	⬆️
romeo/asset-contract/tests/asset_test.clar	74.07% <67.85%> (-8.79%)	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[setzeus]

Pulled & ran locally, can confirm all unit tests passing - LGTM.

[setzeus]

Additional comment but re-reading everything here I'm not sure why we now have two clarity-bitcoin-mini files?

We now have our original one & a "boot" version with v little difference. I don't think that was part of this commit history but wanted to flag that we likely have a duplicate file - is this intentional @friedger ?

[friedger]

@setzeus we have two versions of the contract, one for unit tests and one for deployment.

Related issue #173

[setzeus]

Pulled & working - LGTM!