Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

gh/workflows: daily: add devenv build #214

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

EmbeddedAndroid
Copy link
Contributor

Summary of Changes

Add devenv container builds to the daily workflow. This is a follow up to: stacks-network/sbtc#212 which it was discussed it would be ideal to build test devenv as part of the daily workflow.

Testing

Risks

No risks, as this adds additional testing

How were these changes tested?

Tested daily workflow in repo fork

What future testing should occur?

Monitor daily workflow results, and fix as needed.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #214 (f8ac5af) into main (f598500) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage   38.80%   38.80%           
=======================================
  Files          44       44           
  Lines        5105     5105           
  Branches       34       34           
=======================================
  Hits         1981     1981           
  Misses       3123     3123           
  Partials        1        1           
Flag Coverage Δ
unittests 87.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

CAGS295
CAGS295 previously approved these changes Oct 3, 2023
@EmbeddedAndroid
Copy link
Contributor Author

Had to bump the timeouts, as it's just on the edge of finishing the builds in 60 minutes.

Copy link
Collaborator

@friedger friedger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We we expect developers to wait that long as well? Could we have a faster build based on existing docker images?

@CAGS295 CAGS295 merged commit d423290 into stacks-archive:main Oct 3, 2023
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants