Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

Increase coverage for bitcoin_client.rs #330

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

CAGS295
Copy link
Contributor

@CAGS295 CAGS295 commented Oct 27, 2023

Summary of Changes

Line coverage
18.56% (72/388) -> 39.65% (205/517)

Testing

Risks

How were these changes tested?

What future testing should occur?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CAGS295 CAGS295 force-pushed the dev/cags295/bitcoin-client branch from 12b0091 to dc088c8 Compare October 27, 2023 18:22
@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (6470223) 43.44% compared to head (221fe2c) 44.82%.
Report is 4 commits behind head on main.

Files Patch % Lines
romeo/src/system.rs 0.00% 20 Missing ⚠️
romeo/src/bitcoin_client.rs 96.82% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #330      +/-   ##
==========================================
+ Coverage   43.44%   44.82%   +1.37%     
==========================================
  Files          45       45              
  Lines        5467     5562      +95     
  Branches       47       47              
==========================================
+ Hits         2375     2493     +118     
+ Misses       3091     3068      -23     
  Partials        1        1              
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CAGS295 CAGS295 force-pushed the dev/cags295/bitcoin-client branch from dc088c8 to 221fe2c Compare October 30, 2023 23:24
@CAGS295 CAGS295 self-assigned this Nov 9, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants