Skip to content
This repository has been archived by the owner on Dec 4, 2024. It is now read-only.

[sBTC DR] chore: Remove deprecated @types/typescript dependency #348

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

moodmosaic
Copy link
Collaborator

Summary:

Removed the deprecated @types/typescript dependency from romeo/asset-contract/package.json as TypeScript provides its own type definitions. This addresses the npm warning seen during installation.

Changes:

  • Removed @types/typescript from romeo/asset-contract/package.json.

Benefits:

  • Simplifies the package dependencies.
  • Eliminates the npm warning related to the deprecated package.

Testing

Once you cd into romeo/asset-contract directory, run npm install and there should be no warnings.

Risks

How were these changes tested?

By cding into romeo/asset-contract directory and running npm install and then npm test.

What future testing should occur?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

(Let me know if there's a style guideline of this project that I can follow, and any changes to the documentation that I should make. There are no dependent changes in downstream modules.)

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6470223) 43.44% compared to head (14ef8bf) 43.44%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #348   +/-   ##
=======================================
  Coverage   43.44%   43.44%           
=======================================
  Files          45       45           
  Lines        5467     5467           
  Branches       47       47           
=======================================
  Hits         2375     2375           
  Misses       3091     3091           
  Partials        1        1           
Flag Coverage Δ
unittests 76.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@moodmosaic
Copy link
Collaborator Author

Gentle ping 🏓 👀

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2023

CLA assistant check
All committers have signed the CLA.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants