This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
[sBTC DR] chore: Remove deprecated @types/typescript dependency #348
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Removed the deprecated
@types/typescript
dependency fromromeo/asset-contract/package.json
as TypeScript provides its own type definitions. This addresses the npm warning seen during installation.Changes:
@types/typescript
fromromeo/asset-contract/package.json
.Benefits:
Testing
Once you
cd
intoromeo/asset-contract
directory, runnpm install
and there should be no warnings.Risks
How were these changes tested?
By
cd
ing intoromeo/asset-contract
directory and runningnpm install
and thennpm test
.What future testing should occur?
Checklist:
(Let me know if there's a style guideline of this project that I can follow, and any changes to the documentation that I should make. There are no dependent changes in downstream modules.)