This repository has been archived by the owner on Dec 4, 2024. It is now read-only.
generated from stacks-network/.github
-
Notifications
You must be signed in to change notification settings - Fork 22
test: Add Codec
trait unit tests
#413
Open
ldiego08
wants to merge
7
commits into
stacks-archive:main
Choose a base branch
from
ldiego08:dev/ldiego08/codec-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldiego08
commented
Nov 17, 2023
CAGS295
suggested changes
Nov 20, 2023
ldiego08
commented
Nov 20, 2023
} | ||
|
||
#[test] | ||
fn should_fail_deserialize_recoverable_signature_with_recovery_id_bytes_out_of_bounds( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recovery ID can only be 0 - 3 i32
. A greater number is out of bounds and should fail to deserialize.
} | ||
|
||
#[test] | ||
fn should_fail_deserialize_recoverable_signature_with_signature_bytes_non_ecdsa( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The signature data is ECDSA, hence if the R or S components are out of bounds, deserialization should fail.
CAGS295
approved these changes
Nov 20, 2023
@CAGS295 seems like merging is blocked due to one workflow needing approval. Is there something else I need to do to get this merged? |
8 tasks
Hi @ldiego08, thank you for your contribution. You need to wait for a core maintainer to approve the workflow. @AshtonStephens |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Add unit tests to
codec.rs
to assertCodec
implementations for the following works as expected:bdk::bitcoin::Amount
bdk::bitcoin::Script
bdk::bitcoin::secp256k1::ecdsa::RecoverableSignature
u64
Add
anyhow
crate tostacks-core
for easy error propagation in unit tests.Testing
Run tests normally via
cargo make test
.Risks
None.
How were these changes tested?
Changes are tests themselves and were verified by running
cargo make test
.What future testing should occur?
None.
Checklist: