Clarify handling of frame_time_offset variables #17

src/stactools/goes_glm/parquet.py

@@ -170,11 +170,9 @@ def create_asset(
 
         var_name = f"{type}_{col}"
         if var_name not in dataset.variables:
-            if col.startswith("frame_"):
-                # Some datasets don't contain these variables so generate files without them
-                logger.warning(
-                    f"Variable {var_name} is missing, not exporting them to geoparquet"
-                )
+            if col.startswith("frame_time_offset"):
+                # Some older datasets don't contain these variables so generate files without them.
+                # See https://github.com/stactools-packages/goes-glm/issues/17
                 continue
             else:
                 raise Exception(f"Variable '{var_name}' is missing")

tests/test_stac.py

@@ -258,7 +258,9 @@ def test_create_item(self) -> None:
 
                     self.assertTrue("cube:variables" in asset)
                     vars = asset["cube:variables"]
-                    self.assertGreaterEqual(len(vars), 45)  # often 48, sometimes less
+                    # Some older files have 45 variables, newer ones have 48. See
+                    # https://github.com/stactools-packages/goes-glm/issues/17#issuecomment-1241875842
+                    self.assertTrue(len(vars) == 45 or len(vars) == 48)
                     for var in vars.values():
                         self.assertTrue("dimensions" in var)
                         self.assertTrue("type" in var)