Add option to fix netCDF issues #17 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
m-mohr
commented
Sep 12, 2022
| raise Exception( | ||
| f"The dataset contains an invalid platform identifier: {dataset.platform_ID}" | ||
| ) | ||
| with Dataset(asset_href, "a", format="NETCDF4") as dataset: |
There was a problem hiding this comment.
Always opening the files for reading is not ideal. On the other hand, scaling the variables manually also doesn't seem ideal.
There was a problem hiding this comment.
🤷 Since there is now an option to fix the netcdf, always opening them for append seems OK.
Closed
pjhartzell
approved these changes
Sep 12, 2022
| raise Exception( | ||
| f"The dataset contains an invalid platform identifier: {dataset.platform_ID}" | ||
| ) | ||
| with Dataset(asset_href, "a", format="NETCDF4") as dataset: |
There was a problem hiding this comment.
🤷 Since there is now an option to fix the netcdf, always opening them for append seems OK.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to fix the _Unsiged issues in some older netCDF files.
See #17 for details. I'll add comments with concerns. Most of the changes in the code are just indentation.