renames and ut

stader-labs · Sep 18, 2023 · 0dbe7f1 · 0dbe7f1
1 parent 27d0002
commit 0dbe7f1
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 2 deletions.
diff --git a/contracts/PermissionedNodeRegistry.sol b/contracts/PermissionedNodeRegistry.sol
@@ -426,7 +426,7 @@ contract PermissionedNodeRegistry is
     /**
      * @notice update the name of an operator
      * @dev only operator msg.sender can update
-     * @param _operatorName new Name of the operator
+     * @param _operatorName new name of the operator
      */
     function updateOperatorName(string calldata _operatorName) external override {
         IPoolUtils(staderConfig.getPoolUtils()).onlyValidName(_operatorName);

diff --git a/contracts/PermissionlessNodeRegistry.sol b/contracts/PermissionlessNodeRegistry.sol
@@ -394,7 +394,7 @@ contract PermissionlessNodeRegistry is
     /**
      * @notice update the name of an operator
      * @dev only operator msg.sender can update
-     * @param _operatorName new Name of the operator
+     * @param _operatorName new name of the operator
      */
     function updateOperatorName(string calldata _operatorName) external override {
         IPoolUtils(staderConfig.getPoolUtils()).onlyValidName(_operatorName);

diff --git a/test/foundry_tests/PermissionedNodeRegistry.t.sol b/test/foundry_tests/PermissionedNodeRegistry.t.sol
@@ -473,6 +473,10 @@ contract PermissionedNodeRegistryTest is Test {
         vm.prank(operatorAddr);
         nodeRegistry.initiateRewardAddressChange(operatorAddr, newOPRewardAddr);
 
+        // passed wrong new reward address by mistake
+        vm.prank(opRewardAddr);
+        nodeRegistry.initiateRewardAddressChange(operatorAddr, vm.addr(666));
+
         vm.prank(opRewardAddr);
         nodeRegistry.initiateRewardAddressChange(operatorAddr, newOPRewardAddr);
 

diff --git a/test/foundry_tests/PermissionlessNodeRegistry.t.sol b/test/foundry_tests/PermissionlessNodeRegistry.t.sol
@@ -541,6 +541,10 @@ contract PermissionlessNodeRegistryTest is Test {
         vm.prank(operatorAddr);
         nodeRegistry.initiateRewardAddressChange(operatorAddr, newOPRewardAddr);
 
+        // passed wrong new reward address by mistake
+        vm.prank(opRewardAddr);
+        nodeRegistry.initiateRewardAddressChange(operatorAddr, vm.addr(666));
+
         vm.prank(opRewardAddr);
         nodeRegistry.initiateRewardAddressChange(operatorAddr, newOPRewardAddr);