Fix lint issues (#235)

* ci: disable and fix lint issues

* chore: update node action

* chore: update max warnings

* ci: disable slither unwanted warnings

* Revert "ci: disable slither unwanted warnings"

This reverts commit 73e7807.

* chore: update Dockerfile

* fix: individual import of contracts

.github/workflows/lint.yml

@@ -18,7 +18,7 @@ jobs:
         with:
           token: ${{ secrets.github_token }}
       - name: Set up nodejs
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v2
         with:
           node-version: 18
       - name: install dependencies (npm)

Dockerfile

@@ -24,6 +24,6 @@ RUN yamlfmt -lint .github/workflows/*.yml
 RUN forge install
 RUN npm run prettier:check
 # RUN slither .
-# RUN npm run lint
+RUN npm run lint
 RUN forge test -v
 RUN forge geiger --check contracts/*.sol contracts/*/*.sol

package.json

@@ -7,7 +7,7 @@
     "test": "forge test -v",
     "prettier:check": "prettier --check \"(contracts|test|script)/**/*.sol\"",
     "prettier:fix": "prettier --write \"(contracts|test|script)/**/*.sol\"",
-    "lint": "solhint -w 3 'contracts/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'",
+    "lint": "solhint 'contracts/**/*.sol' 'test/**/*.sol' 'script/**/*.sol'",
     "upgrade:arbitrum": "npx hardhat run scripts/safe-scripts/upgrade.ts --network arbitrum",
     "upgrade:playground:arbitrum": "npx hardhat run scripts/safe-scripts/upgradePlayground.ts --network arbitrum"
   },

test/foundry_tests/NodeELRewardVault.t.sol

@@ -2,8 +2,8 @@
 pragma solidity 0.8.16;
 
 import { Test } from "forge-std/Test.sol";
+// solhint-disable no-console
 import { console2 } from "forge-std/console2.sol";
-
 import { TransparentUpgradeableProxy } from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
 import { ProxyAdmin } from "@openzeppelin/contracts/proxy/transparent/ProxyAdmin.sol";
 

test/foundry_tests/PermissionedPool.t.sol

@@ -109,7 +109,7 @@ contract PermissionedPoolTest is Test {
         address externalEOA = vm.addr(1000);
         startHoax(externalEOA);
         vm.expectRevert(IStaderPoolBase.UnsupportedOperation.selector);
-        payable(permissionedPool).call{ value: 1 ether }('abi.encodeWithSignature("nonExistentFunction()")');
+        payable(permissionedPool).call{ value: 1 ether }(abi.encodeWithSignature("nonExistentFunction()"));
         vm.stopPrank();
     }
 

test/foundry_tests/PermissionlessPool.t.sol

@@ -106,7 +106,7 @@ contract PermissionlessPoolTest is Test {
         address externalEOA = vm.addr(1000);
         startHoax(externalEOA);
         vm.expectRevert(IStaderPoolBase.UnsupportedOperation.selector);
-        payable(permissionlessPool).call{ value: 1 ether }('abi.encodeWithSignature("nonExistentFunction()")');
+        payable(permissionlessPool).call{ value: 1 ether }(abi.encodeWithSignature("nonExistentFunction()"));
         vm.stopPrank();
     }
 

test/foundry_tests/SDIncentiveController.t.sol

@@ -17,6 +17,7 @@ import "forge-std/Test.sol";
 import "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
 import "@openzeppelin/contracts/proxy/transparent/ProxyAdmin.sol";
 
+// solhint-disable no-console
 contract SDIncentiveControllerTest is Test {
     event EmissionRateUpdated(uint256 newEmissionRate);
     event RewardEndBlockUpdated(uint256 newRewardEndBlock);

test/foundry_tests/StaderStakePoolManager.t.sol

@@ -117,7 +117,7 @@ contract StaderStakePoolManagerTest is Test {
         address externalEOA = vm.addr(1000);
         startHoax(externalEOA);
         vm.expectRevert(IStaderStakePoolManager.UnsupportedOperation.selector);
-        payable(stakePoolManager).call{ value: 1 ether }('abi.encodeWithSignature("nonExistentFunction()")');
+        payable(stakePoolManager).call{ value: 1 ether }(abi.encodeWithSignature("nonExistentFunction()"));
         vm.stopPrank();
     }
 

test/foundry_tests/ValidatorWithdrawalVault.t.sol

@@ -2,7 +2,6 @@
 pragma solidity 0.8.16;
 
 import { Test } from "forge-std/Test.sol";
-import { console2 } from "forge-std/console2.sol";
 
 import { TransparentUpgradeableProxy } from "@openzeppelin/contracts/proxy/transparent/TransparentUpgradeableProxy.sol";
 import { ProxyAdmin } from "@openzeppelin/contracts/proxy/transparent/ProxyAdmin.sol";