fix: call internal function and allow manager to grant and revoke per…

…â�missions
stader-labs · Oct 3, 2024 · 76100fa · 76100fa
1 parent ac8e162
commit 76100fa
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 6 deletions.
diff --git a/contracts/StaderConfig.sol b/contracts/StaderConfig.sol
@@ -302,19 +302,19 @@ contract StaderConfig is IStaderConfig, AccessControlUpgradeable {
         address contractAddress,
         string calldata functionSig,
         address accountToPermit
-    ) external override onlyRole(DEFAULT_ADMIN_ROLE) {
+    ) external override onlyRole(MANAGER) {
         bytes32 role = keccak256(abi.encodePacked(contractAddress, functionSig));
-        grantRole(role, accountToPermit);
+        _grantRole(role, accountToPermit);
         emit PermissionGranted(accountToPermit, contractAddress, functionSig);
     }
 
     function revokeCallPermission(
         address contractAddress,
         string calldata functionSig,
         address accountToRevoke
-    ) external override onlyRole(DEFAULT_ADMIN_ROLE) {
+    ) external override onlyRole(MANAGER) {
         bytes32 role = keccak256(abi.encodePacked(contractAddress, functionSig));
-        revokeRole(role, accountToRevoke);
+        _revokeRole(role, accountToRevoke);
         emit PermissionRevoked(accountToRevoke, contractAddress, functionSig);
     }
 

diff --git a/test/foundry_tests/PoolSelector.t.sol b/test/foundry_tests/PoolSelector.t.sol
@@ -63,8 +63,10 @@ contract PoolSelectorTest is Test {
         staderConfig.updateStakePoolManager(staderStakePoolManager);
         staderConfig.grantRole(staderConfig.MANAGER(), staderManager);
         staderConfig.grantRole(staderConfig.OPERATOR(), operator);
-        staderConfig.giveCallPermission(address(poolSelector), "updatePoolWeights(uint256[])", configurator);
         vm.stopPrank();
+
+        vm.prank(staderManager);
+        staderConfig.giveCallPermission(address(poolSelector), "updatePoolWeights(uint256[])", configurator);
     }
 
     function test_JustToIncreaseCoverage() public {

diff --git a/test/foundry_tests/PoolUtils.t.sol b/test/foundry_tests/PoolUtils.t.sol
@@ -63,8 +63,10 @@ contract PoolUtilsTest is Test {
         vm.startPrank(staderAdmin);
         staderConfig.grantRole(staderConfig.MANAGER(), staderManager);
         staderConfig.grantRole(staderConfig.OPERATOR(), operator);
-        staderConfig.giveCallPermission(address(poolUtils), "processValidatorExitList(bytes[])", configurator);
         vm.stopPrank();
+
+        vm.prank(staderManager);
+        staderConfig.giveCallPermission(address(poolUtils), "processValidatorExitList(bytes[])", configurator);
     }
 
     function test_JustToIncreaseCoverage() public {