reward address change and unit tests #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manoj9april
commented
Sep 7, 2023
•
manoj9april
commented
- reward address change is a 2 step process now
- separated out reward address and opName change
- updated unit tests
sanjay-staderlabs
suggested changes
Sep 11, 2023
added 3 commits
September 13, 2023 19:49
0xb10ckdev
reviewed
Sep 14, 2023
sanjay-staderlabs
approved these changes
Sep 14, 2023
| UtilLib.checkNonZeroAddress(_rewardAddress); | ||
| uint256 _operatorId = operatorIDByAddress[_operatorAddress]; | ||
| address operatorRewardAddress = operatorStructById[_operatorId].operatorRewardAddress; |
galacticminter
approved these changes
Sep 18, 2023
galacticminter
approved these changes
Sep 21, 2023
jac18281828
pushed a commit
that referenced
this pull request
Apr 18, 2024
* reward address change and unit tests * rename * added ut for invalid operator * rename * renames and ut * renames
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.