SD Collateral Deposit Using SD Reward #208
Conversation
| if (!IERC20(staderConfig.getStaderToken()).transferFrom(msg.sender, address(this), _sdAmount)) { | ||
| revert SDTransferFailed(); | ||
| } | ||
| operatorSDBalance[_operator] += _sdAmount; |
There was a problem hiding this comment.
Although not required here. But it is recommended to follow check-effects-interaction security pattern.
i.e. move line 64 to line 61
https://fravoll.github.io/solidity-patterns/checks_effects_interactions.html
There was a problem hiding this comment.
I think it follows this pattern, you do not want to increase operatorSDBalance before you get SD in the contract, the main aim of check-effects-interaction is if your interaction calls get hacked then your storage should not be exploited, if we move line 64 to 61 then in case tranferFrom does not work properly your operatorSDBalance will keep on increasing.
@dulguun-staderlabs would love to hear your thoughts here
There was a problem hiding this comment.
transactions are atomic, hence whole txn will revert if transferFrom fails.
sanjay-staderlabs
changed the base branch from
mainnet_V0
to
feat/SD_Utility_Pool
sanjay-staderlabs
changed the title
Below are the changes across SDCollateral.sol and SocializingPool.sol