fixing continuous integration #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jac18281828
force-pushed
the
jac/cibuildfix
branch
2 times, most recently
from
e4889cc to
891f3f6
Compare
jac18281828
force-pushed
the
jac/cibuildfix
branch
from
84508f2 to
366e9d0
Compare
Fixes for NodeELRewardVault.t Fixes for solidity formatting: - bracketSpacing - double quote - no tabs Fixes test_withdraw in NodeELRewardVault.t.sol Pass operator address as argument to NodeRegistryMock rebase changes from mainnet_V0 fixing hoax prank issues ValidatorWithdrawalVaultTest is passing PermissionlessNodeRegistryTest.test_markReadyToDepositValidator is passing PermissionlessNodeRegistryTest.test_getAllActiveValidatorsWithZeroPageNumber is passing PermissionlessNodeRegistryTest.test_getAllActiveValidators is passing PermissionlessPoolTest.test_setCommisionFeesWithInvalidInput is passing PermissionedPoolTest.test_StakeUserETHToBeaconChain is passing OperatorRewardsCollectorTest passing All tests passing
jac18281828
force-pushed
the
jac/cibuildfix
branch
3 times, most recently
from
16cd620 to
5caad1d
Compare
|
Tests are now passing!
|
- adding support for code coverage analytics - SDUtilityPoolTest.test_RequestWithdraw - cleanup test with fuzzer range issues - adding manual workflow dispatch
jac18281828
force-pushed
the
jac/cibuildfix
branch
from
5caad1d to
f545abe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #217