Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

238: fixing lint issues with imports #239

Merged
merged 1 commit into from
Jun 19, 2024
Merged

238: fixing lint issues with imports #239

merged 1 commit into from
Jun 19, 2024

Conversation

jac18281828
Copy link
Contributor

@jac18281828 jac18281828 commented Jun 18, 2024

closes #238

This cleans up many minor issues with imports. All remaining lint warnings are invasive issues that should be considered on their own.

@jac18281828 jac18281828 added the enhancement New feature or request label Jun 18, 2024
@jac18281828 jac18281828 self-assigned this Jun 18, 2024
@jac18281828 jac18281828 requested a review from blockgroot June 18, 2024 20:12
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.11%. Comparing base (12d8ccf) to head (bd7e239).

Files Patch % Lines
contracts/ValidatorWithdrawalVault.sol 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   89.11%   89.11%   -0.01%     
==========================================
  Files          42       42              
  Lines        2555     2553       -2     
  Branches      298      298              
==========================================
- Hits         2277     2275       -2     
  Misses        194      194              
  Partials       84       84              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.solhint.json Show resolved Hide resolved
package.json Show resolved Hide resolved
contracts/PermissionlessNodeRegistry.sol Outdated Show resolved Hide resolved
@jac18281828 jac18281828 requested a review from blockgroot June 19, 2024 14:43
@jac18281828 jac18281828 force-pushed the jac/ethxlint branch 2 times, most recently from 6d45145 to 94ebced Compare June 19, 2024 15:13
@jac18281828 jac18281828 merged commit bd7e239 into main Jun 19, 2024
5 of 8 checks passed
@jac18281828 jac18281828 deleted the jac/ethxlint branch June 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve non-invasive lint issues
2 participants