Make improvements to method to request withdrawal

stader-labs · Sep 10, 2024 · 59ea07e · 59ea07e
1 parent 40706ff
commit 59ea07e
Show file tree

Hide file tree

Showing 3 changed files with 382 additions and 42 deletions.
diff --git a/.solhint.json b/.solhint.json
@@ -22,7 +22,7 @@
         "func-named-parameters": ["error", 12],
         "func-param-name-mixedcase": "error",
         "func-visibility": ["error", { "ignoreConstructors": true }],
-        "function-max-lines": ["error", 80],
+        "function-max-lines": ["error", 100],
         "gas-custom-errors": "off",
         "immutable-vars-naming": ["error", { "immutablesAsConstants": false }],
         "imports-on-top": "error",

diff --git a/contracts/MaticX.sol b/contracts/MaticX.sol
@@ -206,76 +206,93 @@ contract MaticX is
 
 		_burn(msg.sender, _amount);
 
-		uint256 leftAmount2WithdrawInStakeToken = totalAmount2WithdrawInStakeToken;
+		uint256 leftAmount2Withdraw = totalAmount2WithdrawInStakeToken;
 		uint256 totalDelegated = getTotalStakeAcrossAllValidators();
 
 		require(
 			totalDelegated >= totalAmount2WithdrawInStakeToken,
 			"Too much to withdraw"
 		);
 
-		uint256[] memory validators = IValidatorRegistry(validatorRegistry)
+		uint256[] memory validatorIds = IValidatorRegistry(validatorRegistry)
 			.getValidators();
 		uint256 preferredValidatorId = IValidatorRegistry(validatorRegistry)
 			.preferredWithdrawalValidatorId();
 
-		uint256 currentIdx = 0;
-		for (; currentIdx < validators.length; ) {
-			if (preferredValidatorId == validators[currentIdx]) {
+		uint256 currentIndex = 0;
+		uint256 validatorIdCount = validatorIds.length;
+		uint256 totalValidatorRequests = validatorIdCount;
+
+		for (; currentIndex < validatorIdCount; ) {
+			if (preferredValidatorId == validatorIds[currentIndex]) {
 				break;
 			}
 			unchecked {
-				 ++currentIdx;
+				++currentIndex;
 			}
 		}
 
-		while (leftAmount2WithdrawInStakeToken > 0) {
-			uint256 validatorId = validators[currentIdx];
-
+		while (totalValidatorRequests > 0 && leftAmount2Withdraw > 0) {
+			uint256 validatorId = validatorIds[currentIndex];
 			address validatorShare = IStakeManager(stakeManager)
 				.getValidatorContract(validatorId);
 			(uint256 validatorBalance, ) = getTotalStake(
 				IValidatorShare(validatorShare)
 			);
 
 			uint256 amount2WithdrawFromValidator = (validatorBalance <=
-				leftAmount2WithdrawInStakeToken)
+				leftAmount2Withdraw)
 				? validatorBalance
-				: leftAmount2WithdrawInStakeToken;
-
-			_pol
-				? IValidatorShare(validatorShare).sellVoucher_newPOL(
-					amount2WithdrawFromValidator,
-					type(uint256).max
-				)
-				: IValidatorShare(validatorShare).sellVoucher_new(
-					amount2WithdrawFromValidator,
-					type(uint256).max
+				: leftAmount2Withdraw;
+
+			if (amount2WithdrawFromValidator > 0) {
+				_pol
+					? IValidatorShare(validatorShare).sellVoucher_newPOL(
+						amount2WithdrawFromValidator,
+						type(uint256).max
+					)
+					: IValidatorShare(validatorShare).sellVoucher_new(
+						amount2WithdrawFromValidator,
+						type(uint256).max
+					);
+
+				userWithdrawalRequests[msg.sender].push(
+					WithdrawalRequest(
+						IValidatorShare(validatorShare).unbondNonces(
+							address(this)
+						),
+						IStakeManager(stakeManager).epoch() +
+							IStakeManager(stakeManager).withdrawalDelay(),
+						validatorShare
+					)
 				);
 
-			userWithdrawalRequests[msg.sender].push(
-				WithdrawalRequest(
-					IValidatorShare(validatorShare).unbondNonces(address(this)),
-					IStakeManager(stakeManager).epoch() +
-						IStakeManager(stakeManager).withdrawalDelay(),
-					validatorShare
-				)
-			);
+				leftAmount2Withdraw -= amount2WithdrawFromValidator;
+			}
 
-			leftAmount2WithdrawInStakeToken -= amount2WithdrawFromValidator;
-			currentIdx = currentIdx + 1 < validators.length
-				? currentIdx + 1
+			--totalValidatorRequests;
+			currentIndex = currentIndex + 1 < validatorIdCount
+				? currentIndex + 1
 				: 0;
 		}
 
+		require(
+			leftAmount2Withdraw == 0,
+			"Insfufficient amount to withdraw from validators"
+		);
+
 		IFxStateRootTunnel(fxStateRootTunnel).sendMessageToChild(
 			abi.encode(
 				totalShares - _amount,
 				totalPooledStakeTokens - totalAmount2WithdrawInStakeToken
 			)
 		);
 
-		emit RequestWithdraw(msg.sender, _amount, totalAmount2WithdrawInStakeToken);
+		emit RequestWithdraw(
+			msg.sender,
+			_amount,
+			totalAmount2WithdrawInStakeToken
+		);
 	}
 
 	/**