Sd utilize #269
bharath-123Annotations
10 errors and 6 warnings
|
build:
stader-lib/socializing-pool/rewards.go#L26
paramTypeCombine: func(sp *stader.SocializingPoolContractManager, index []*big.Int, amountSd []*big.Int, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (stader.GasInfo, error) could be replaced with func(sp *stader.SocializingPoolContractManager, index, amountSd, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (stader.GasInfo, error) (gocritic)
|
|
build:
stader-lib/socializing-pool/rewards.go#L30
paramTypeCombine: func(sp *stader.SocializingPoolContractManager, index []*big.Int, amountSd []*big.Int, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (*types.Transaction, error) could be replaced with func(sp *stader.SocializingPoolContractManager, index, amountSd, amountEth []*big.Int, merkleProof [][][32]byte, opts *bind.TransactOpts) (*types.Transaction, error) (gocritic)
|
|
build:
stader/guardian/collector/network-collector.go#L65
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
build:
stader/guardian/collector/network-collector.go#L154
commentFormatting: put a space between `//` and comment text (gocritic)
|
|
build:
stader-cli/node/claim-sp-rewards.go#L184
elseif: can replace 'else {if cond {}}' with 'else if cond {}' (gocritic)
|
|
build:
stader-cli/node/commands.go#L370
unlambda: replace `func(c *cli.Context) error {
|
|
build:
stader/api/validator/deposit.go#L113
cyclomatic complexity 32 of func `canNodeDeposit` is high (> 30) (gocyclo)
|
|
build:
stader/guardian/collector/operator-collector.go#L146
`positon` is a misspelling of `position` (misspell)
|
|
build:
stader/guardian/collector/operator-collector.go#L227
unnecessary conversion (unconvert)
|
|
build:
stader/guardian/collector/operator-collector.go#L228
unnecessary conversion (unconvert)
|
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-go@v3, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
build:
stader-lib/sdutility/sd-utility.go#L118
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
|
|
build:
stader-lib/node/validator.go#L22
var-naming: func parameter referralId should be referralID (revive)
|
|
build:
stader-lib/node/validator.go#L42
var-naming: func parameter referralId should be referralID (revive)
|
|
build:
stader/api/node/claim-rewards.go#L100
var-naming: var operatorId should be operatorID (revive)
|
|
build:
stader/api/node/utility-sd.go#L42
var-naming: var operatorId should be operatorID (revive)
|