Min to utility always be 1 SD

stader-labs · Mar 1, 2024 · 466e9d1 · 466e9d1
1 parent 63c4f42
commit 466e9d1
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 7 deletions.
diff --git a/stader-cli/node/utilize-sd.go b/stader-cli/node/utilize-sd.go
@@ -58,7 +58,10 @@ func utilizeSD(c *cli.Context) error {
 		return nil
 	}
 
-	amountWei, err := PromptChooseUtilityAmount(sdStatusResponse.SDStatus)
+	minUtility := eth.EthToWei(1)
+	maxUtility := GetMaxUtility(sdStatusResponse.SDStatus)
+
+	amountWei, err := PromptChooseUtilityAmount(sdStatusResponse.SDStatus, minUtility, maxUtility)
 	if err != nil {
 		return err
 	}
@@ -120,10 +123,7 @@ func GetMaxUtility(sdStatus *api.SdStatusResponse) *big.Int {
 	return maxUtility
 }
 
-func PromptChooseUtilityAmount(sdStatus *api.SdStatusResponse) (*big.Int, error) {
-	minUtility := GetMinUtility(sdStatus)
-	maxUtility := GetMaxUtility(sdStatus)
-
+func PromptChooseUtilityAmount(sdStatus *api.SdStatusResponse, minUtility, maxUtility *big.Int) (*big.Int, error) {
 	// 1. If the pool had enough SD
 	if minUtility.Cmp(sdStatus.PoolAvailableSDBalance) > 0 {
 		return nil, errors.New("There is not sufficient free SD in the Utility Pool for utilization at the moment. Please try again later when there is enough free SD in the Utility Pool")

diff --git a/stader-cli/validator/deposit.go b/stader-cli/validator/deposit.go
@@ -106,7 +106,10 @@ func nodeDeposit(c *cli.Context) error {
 
 		switch i {
 		case 0:
-			utilityAmount, err = node.PromptChooseUtilityAmount(sdStatus)
+			minUtility := node.GetMinUtility(sdStatus)
+			maxUtility := node.GetMaxUtility(sdStatus)
+
+			utilityAmount, err = node.PromptChooseUtilityAmount(sdStatus, minUtility, maxUtility)
 			if err != nil {
 				return err
 			}

diff --git a/stader/node/node.go b/stader/node/node.go
@@ -471,7 +471,7 @@ func run(c *cli.Context) error {
 			if response.Success {
 				infoLog.Println("Successfully sent the NodeDiversity message")
 			} else {
-				errorLog.Println("Failed to send the NodeDiversity message with err: %s\n", response.Error)
+				errorLog.Printf("Failed to send the NodeDiversity message with err: %s\n", response.Error)
 			}
 
 			infoLog.Println("Done checking node diversity metrics")