Initial pass at supporting wasm32-unknown-unknown in a web browser #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianthetechie
commented
Jun 13, 2024
Comment on lines
+21
to
+24
| #[cfg_attr( | ||
| feature = "std", | ||
| error("Failed to generate a polyline from route coordinates: {error}.") | ||
| )] |
There was a problem hiding this comment.
For no_std platforms, we cannot implement Error because the type is from std. However, in a few months (October), Error is moving from std to core :D
This was referenced Jun 14, 2024
CatMe0w
reviewed
Jun 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at
wasm32-unknown-unknown, specifically for web browsers.I'll leave some comments with the key pieces, but broadly speaking, this should have no functional changes (only some error APIs change).
This incidentally does like 95% of the work for #26.