Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cronjob): Corrected indentation of securityContext container params #minor #354

Merged
merged 2 commits into from
Oct 28, 2024
Merged

feat(cronjob): Corrected indentation of securityContext container params #minor #354

merged 2 commits into from
Oct 28, 2024

Conversation

epm-marcus
Copy link
Contributor

Corrected the indentation level of securityContext to instead apply it to each container within the jobs.

@karl-johan-grahn karl-johan-grahn merged commit 57b9d1c into stakater:master Oct 28, 2024
3 checks passed
@aslafy-z
Copy link
Collaborator

Why was this PR merged?
It is a breaking change.
Job can have a pod level or container level security context.
I think it should be reverted and a new PR should be emitted to add containerSecurityContext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karl-johan-grahn karl-johan-grahn karl-johan-grahn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@epm-marcus @aslafy-z @karl-johan-grahn