Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cache genesis call #17

Merged
merged 3 commits into from
Jan 2, 2024
Merged

feat: cache genesis call #17

merged 3 commits into from
Jan 2, 2024

Conversation

mateuszsokola
Copy link
Collaborator

@mateuszsokola mateuszsokola commented Jan 2, 2024 •
edited
Loading

I decided to implement caching per AsyncBeacon instance rather than the base_url. Our services are using one instance of AsyncBeacon rather than initialize multiple instances.

@mateuszsokola mateuszsokola linked an issue Jan 2, 2024 that may be closed by this pull request
Cache genesis call in web3-utils package #16
Closed
@mateuszsokola mateuszsokola marked this pull request as ready for review January 2, 2024 16:32
mbaranovski
mbaranovski approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@mbaranovski mbaranovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! thanks, let's publish it and use in the oracle

@mateuszsokola mateuszsokola merged commit 14b9216 into main Jan 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbaranovski mbaranovski mbaranovski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache genesis call in web3-utils package
2 participants
@mateuszsokola @mbaranovski