Remove support for outdated DiffSinger script files #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When stakira/OpenUtau first became compatible with DiffSinger, the early versions of DiffSinger, along with its corresponding datasets and project file specifications, had already been replaced by newer versions.
OpenVPI completely removed compatibility with the old version's dataset in their fork of DiffSinger v2.3.0, and now almost no one should be using this outdated specification.
In OpenUtau, exporting old version DiffSinger scripts is labeled as 'Export DiffSinger Scripts To,' which can easily create the illusion that both the old and new versions are compatible with each other. I think this should be removed, or at the very least, marked somewhere as 'outdated.'