-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhancement]: Support tikv as a redis replacement #634
Comments
Looks similar to FoundationDB. I will work on it. Working branch: https://github.com/alvinpeters/stalwart-mail-server/tree/add-tikv |
@williamdes LOL I got it working somehow (albeit in a shithouse condition). Wanna help me dogfood/test this? You can clone and compile the branch now: git clone --branch add-tikv https://github.com/alvinpeters/stalwart-mail-server.git
cd stalwart-mail-server
cargo build --bin stalwart-mail --features tikv Since web-admin doesn't show it yet, you'd have to manually add it to the config.toml:
Then, you have to manually set the stores used since you can't just select it in the web admin, like:
Currently setting up tests. I reckon I can get this in a ready shape within next week. |
Thank you so much, I will help you testing |
@alvinpeters have you tried running the store tests? Add the $ cd tests
$ STORE=tikv cargo test store_tests -- --nocapture If that works try with the IMAP and JMAP tests: $ STORE=tikv cargo test imap_tests -- --nocapture
$ STORE=tikv cargo test jmap_tests -- --nocapture |
Thanks! I didn't know how to properly run the test, so was only testing by just running the entire thing and was working kinda smoothly lol. Either I messed up with the blobbing or I set the limit too high. I'll fix it when I wake up.
Should I submit a PR now so other people can easily contribute? |
I definitely think a PR would be great to discuss the implementation |
Good thing I saw this before I sleep. Submitted #668 and stalwartlabs/webadmin#15 as draft PRs so other people can see/help. |
Thank you for the implementation, it will help me if I try to implement etcd etcd is used in the PD of TiKV I am still searching for the best lightweight solution to setup. For now TiKV launches quite a lot of processes and requires a PD process. Will keep you all updated Update 1, see: #742 for etcd PS (personal opinion): I think that having to use software like tiup to run a setup is bullshit, it is nice to have but hides config details. Xline and etcd are much simpler, just run them after install. No downloading of components.. |
Which feature or improvement would you like to request?
See #23 as a thread reference
https://github.com/tikv/tikv
https://github.com/tikv/client-rust
Please let me know if this is a viable option to be implemented, so I can do the server setup and let you know if it works like it promises.
To be noted that in fact it runs a RocksDB on each node.
See https://tikv.org/docs/7.1/reference/architecture/storage/
Also, why can tikv not also be a data store?
Is your feature request related to a problem?
I do not want to deploy Redis, and will probably deploy something that I feel is better designed for multi site/datacenter
Code of Conduct
The text was updated successfully, but these errors were encountered: