-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TiKV as a data store backend #668
Draft
alvinpeters
wants to merge
20
commits into
stalwartlabs:main
Choose a base branch
from
alvinpeters:add-tikv
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 4, 2024
mdecimus
reviewed
Aug 27, 2024
williamdes
reviewed
Aug 29, 2024
Passed all tests until Store query tests
Can you enable GitHub actions on your fork repository so it is easier to access tests reports please? |
Done. Although, I am kinda clueless on how to test a specific backend using a GA workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add TiKV as a backend to all store types. All help/reviews/roasting my shitty coding welcome!
Resolves #634
To do's:
Can I trust this branch with my personal emails?
No.
Current issues (2338f08):
Fail on Store query tests (first errors are 'failed to resolve lock' then the last errors show 'epoch not match')
Development/testing environment:
tiup playground
Running and testing yourself
Expand me
Config entry:
Building:
git clone --branch add-tikv https://github.com/alvinpeters/stalwart-mail-server.git cd stalwart-mail-server cargo build --bin stalwart-mail --features tikv
I'm too tired to add the running and setting up webadmin. Will do tomorrow lol
Testing: