Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mysql feature also needs futures #598

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

williamdes
Copy link
Contributor

@williamdes williamdes commented Jul 7, 2024

cargo build --manifest-path crates/main/Cargo.toml --release --bin stalwart-mail --no-default-features --features sqlite,mysql,s3,redis

@mdecimus
Copy link
Member

mdecimus commented Jul 7, 2024

Why this change? It is not required by the mysql store implementation.

@williamdes
Copy link
Contributor Author

Why this change? It is not required by the mysql store implementation.

Run my command and you will see the mysql feature can not build ;)

error[E0432]: unresolved import `futures`
 --> crates/store/src/backend/mysql/read.rs:7:5
  |
7 | use futures::TryStreamExt;
  |     ^^^^^^^ help: a similar path exists: `mysql_async::futures`

error[E0432]: unresolved import `futures`
  --> crates/store/src/backend/mysql/write.rs:10:5
   |
10 | use futures::TryStreamExt;
   |     ^^^^^^^ help: a similar path exists: `mysql_async::futures`

@mdecimus mdecimus merged commit 4164598 into stalwartlabs:main Jul 8, 2024
11 of 12 checks passed
@williamdes williamdes deleted the fix-mysql-feature branch July 8, 2024 13:52
swerter pushed a commit to swerter/mail-server that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants