-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Don't Merge] Trigger codegen change to run CI #1423
Conversation
Hey @serban-nicusor-toptal - could you tell if anything is different from these runs and https://jenkins.flatironinstitute.org/blue/organizations/jenkins/Stan%2FStanc3/detail/PR-1396/1/pipeline/311/? As far as I can tell, nothing in the code has changed to cause the end-to-end at O1 to fail |
I think the difference is that the successful one ran on |
@serban-nicusor-toptal failed even on jenkins2, any other leads? |
I ran it once on |
I agree the diff is not very useful, but I also diffed the generated code from the current |
Looking at the docker image, I see that https://hub.docker.com/layers/stanorg/ci/gpu-cpp17/images/sha256-f5f87c58cf7809f76c851e94b0e7919b95236f327fe402e75ffcf175a0f9f6e9?context=explore Tho it looks like |
I'm guessing it might have been an underlying hardware change. Unless something changed in Math and we missed it? @andrjohns has there been any movement in the |
Hey @dylex - has the jenkins hardware changed appreciably since ~Jan 31? We're seeing some different numerical behavior compared to then, even if we try older versions of our code |
I believe the last hardware change to jenknis was Nov last year, when we upgraded the jenkins control node. |
Seems like this resolved itself? |
That is for sure weird but I'm glad it's working now. |
#1422 is failing for a reason I suspect is unrelated to the changes there so I wanted to run CI independently.