Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cap the size of the core writer task rather than the number of batches #762

Merged
merged 3 commits into from
Oct 11, 2024
Merged

cap the size of the core writer task rather than the number of batches #762

merged 3 commits into from
Oct 11, 2024

Conversation

dlwh
Copy link
Member

@dlwh dlwh commented Oct 11, 2024 •
edited
Loading

This is marginally slower, but pile now builds fine on a v4-32, which is an improvement.

abhinavg4
abhinavg4 approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@abhinavg4 abhinavg4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@dlwh dlwh merged commit c3b3dd8 into main Oct 11, 2024
8 checks passed
@dlwh dlwh deleted the multicache branch October 11, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavg4 abhinavg4 abhinavg4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlwh @abhinavg4