Changes in how parquet is read #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlwh
approved these changes
Oct 15, 2024
|
|
||
| # read from the starting row group onwards | ||
| for rg_idx in range(row_group_index, parquet_file.num_row_groups): | ||
| table = parquet_file.read_row_group(rg_idx) |
There was a problem hiding this comment.
Now I’m concerned this is a disk seek but probably not worth worrying about
| raise ValueError(f"Unknown format {format}") | ||
| case ".parquet": | ||
| with fsspec.open(url, "rb", compression=compression) as f: | ||
| parquet_file = pq.ParquetFile(f) |
There was a problem hiding this comment.
the logic in this block is complex enough and duplicated enough i'd prefer if you extracted a method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #763 and addresses David's comments in #764