Relax restriction on scipy to be compatible with more recent numpy #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, definitely vestigial! There was like a week where JAX didn't work without the bound and I forgot to fix it! Probably we can just delete it since we don't use scipy directly |
|
Hi @jennifgcrl , thanks for raising this! I'm just gonna delete the dependency (in #797) instead, which should be at least as good. (If I'm wrong, let me know!) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct me if I'm wrong but I think the <=1.12.0 bound on scipy is now vestigial? In any case, it's causing conflicts with other packages (e.g., most recent jax) that require a too new version of numpy for scipy to handle.