Add sequence packing for lm-eval-harness #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikil-ravi
reviewed
Jan 8, 2025
scripts/gcs_bulk_delete.py
Outdated
There was a problem hiding this comment.
was this intended to be part of the PR? Just checking
There was a problem hiding this comment.
nah, but i don't care enough to take it out :-)
nikil-ravi
reviewed
Jan 8, 2025
nikil-ravi
reviewed
Jan 8, 2025
nikil-ravi
approved these changes
Jan 8, 2025
|
Curious whether we know the rough ratio of padding:non padding tokens with this packing strategy? |
Co-authored-by: Nikil Ravi <[email protected]>
|
It's about 90% real tokens (as opposed to ~90% padding before) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup was less than I hoped, but I think that can be improved with better packing strategies (and also removing some batching overhead. the bottleneck is now data loading??)