Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FalkordbRM Retriever Class for Enhanced Querying and Embedding Retrieval #1653

Merged
merged 9 commits into from
Nov 6, 2024

Conversation

kingtroga
Copy link
Contributor

This pull request introduces the FalkordbRM retriever class, designed to integrate FalkorDB for efficient querying and passage retrieval based on embeddings. The class supports both local and cloud-based FalkorDB sessions and uses OpenAI's embedding services by default

Key Changes:

  1. FalkordbRM Retriever Class
  2. Embedding Provider Integration
  3. Error Handling
  4. Customization Options

@gkorland
Copy link

gkorland commented Nov 3, 2024

@okhat @arnavsinghvi11 can you please merge?

@arnavsinghvi11
Copy link
Collaborator

Thanks @kingtroga @gkorland for this PR! Seems like some merge conflicts should be resolved if you pull from current main! should pass the failing test as well

also added a comment to support pip install dspy-ai[falkordb] correctly.

@kingtroga
Copy link
Contributor Author

@arnavsinghvi11 I've made the necessary changes. Please try the merge again 🙏🏾

@kingtroga
Copy link
Contributor Author

@arnavsinghvi11

@arnavsinghvi11
Copy link
Collaborator

Thanks @kingtroga !

we're currently planning an internal refactor of how we support RMs in DSPy and hence will leave this PR open to avoid any future code reversions. However, if the PR requires merging to be usable in DSPy, we'll do so! Please let us know

@kingtroga
Copy link
Contributor Author

Hi @arnavsinghvi11 , thanks for the update! This PR does need merging to be usable in DSPy. Let me know if there's anything I can do to help with it.

@arnavsinghvi11 arnavsinghvi11 merged commit 89c33f2 into stanfordnlp:main Nov 6, 2024
6 checks passed
@arnavsinghvi11
Copy link
Collaborator

Thanks @kingtroga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants