WIP - dspy.RM/retrieve refactor #1739
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnavsinghvi11
commented
Nov 1, 2024
dspy/retrieve/embedder.py
Outdated
| from typing import Callable, List, Optional | ||
|
|
||
|
|
||
| class Embedder: |
There was a problem hiding this comment.
#1735 will go here once merged @chenmoneygithub
| def __init__(self, url: str = "http://0.0.0.0", port: Optional[Union[str, int]] = None, post_requests: bool = False): | ||
| super().__init__(embedder=None) | ||
| self.post_requests = post_requests | ||
| self.url = f"{url}:{port}" if port else url |
There was a problem hiding this comment.
Is this port required? If so let's raise an ValueError for clear action.
There was a problem hiding this comment.
just an optional i believe. our examples typically use 'http://20.102.90.50:2017/wiki17_abstracts' where the port can be specified in the URL
| return res.json()["topk"][:k] | ||
|
|
||
|
|
||
| @functools.cache |
There was a problem hiding this comment.
why do we need this _wrapped function? seems it's not adding extra logic except from some cache, call we move the annotations to colbertv2_post_request_v2?
There was a problem hiding this comment.
yea i think we can simplify it but will defer to @okhat as this was existing behavior from colbertv2.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactoring for cleaner retriever interface in DSPy