Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support resource group #4374

Draft
wants to merge 9 commits into
base: nkysg/compiler-v2-update
Choose a base branch
from

Conversation

simonjiao
Copy link
Collaborator

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

@simonjiao simonjiao requested review from welbon and nkysg January 16, 2025 08:00
Copy link

coderabbitai bot commented Jan 16, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@simonjiao simonjiao force-pushed the support-resource-group branch from 840d4f9 to b898024 Compare January 17, 2025 09:17
@simonjiao simonjiao force-pushed the support-resource-group branch from b898024 to 5025139 Compare January 17, 2025 23:50
@simonjiao simonjiao marked this pull request as ready for review January 17, 2025 23:58
@simonjiao simonjiao requested a review from jolestar as a code owner January 17, 2025 23:58
@simonjiao simonjiao removed the request for review from jolestar January 17, 2025 23:58
@simonjiao simonjiao force-pushed the support-resource-group branch from 3981826 to df4325a Compare January 19, 2025 14:00
@simonjiao simonjiao marked this pull request as draft January 19, 2025 14:00
Copy link

Benchmark for 1dd51d6

Click to view benchmark
Test Base PR %
accumulator_append 777.6±112.19µs 826.1±141.02µs +6.24%
block_apply/block_apply_10 463.6±14.77ms 669.4±39.88ms +44.39%
block_apply/block_apply_1000 54.6±1.13s 77.8±2.18s +42.49%
get_with_proof/db_store 43.7±2.20µs 43.9±3.33µs +0.46%
get_with_proof/mem_store 41.3±9.20µs 36.9±6.21µs -10.65%
put_and_commit/db_store/1 117.7±6.46µs 127.2±8.94µs +8.07%
put_and_commit/db_store/10 1072.7±46.59µs 1079.2±81.99µs +0.61%
put_and_commit/db_store/100 9.6±0.58ms 9.7±0.86ms +1.04%
put_and_commit/db_store/5 582.8±57.44µs 549.5±24.58µs -5.71%
put_and_commit/db_store/50 5.3±0.42ms 5.0±0.25ms -5.66%
put_and_commit/mem_store/1 73.1±10.72µs 71.3±7.70µs -2.46%
put_and_commit/mem_store/10 668.4±76.40µs 678.6±84.35µs +1.53%
put_and_commit/mem_store/100 6.4±0.53ms 6.4±0.75ms 0.00%
put_and_commit/mem_store/5 333.2±33.56µs 332.9±32.80µs -0.09%
put_and_commit/mem_store/50 3.3±0.34ms 3.1±0.14ms -6.06%
query_block/query_block_in(10)_times(100) 12.0±0.62ms 11.9±0.67ms -0.83%
query_block/query_block_in(10)_times(1000) 118.8±9.10ms 122.8±5.12ms +3.37%
query_block/query_block_in(10)_times(10000) 1159.6±37.48ms 1185.0±63.80ms +2.19%
query_block/query_block_in(1000)_times(100) 1137.8±41.79µs 1241.8±69.30µs +9.14%
query_block/query_block_in(1000)_times(1000) 12.6±0.81ms 15.5±4.69ms +23.02%
query_block/query_block_in(1000)_times(10000) 115.4±1.65ms 116.3±2.33ms +0.78%
storage_transaction 1094.3±428.73µs 1166.4±489.02µs +6.59%
vm/transaction_execution/1 602.1±21.54ms 981.2±51.25ms +62.96%
vm/transaction_execution/10 234.0±11.58ms 486.8±35.88ms +108.03%
vm/transaction_execution/20 234.7±18.50ms 489.2±26.20ms +108.44%
vm/transaction_execution/5 281.2±12.09ms 508.2±34.22ms +80.73%
vm/transaction_execution/50 272.0±19.72ms 840.3±130.72ms +208.93%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant