fix: add starkid improvements #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fricoben
force-pushed
the
fix/starkid-improvements
branch
from
3047892 to
cd2bfc4
Compare
penovicp
requested changes
Jan 28, 2025
__tests__/account.starknetId.test.ts
Outdated
| @@ -85,6 +85,12 @@ describe('deploy and test Wallet', () => { | |||
| expect(hexToDecimalString(address)).toEqual(hexToDecimalString(account.address)); | |||
| }); | |||
|
|
|||
| test('Should throw error when invalid stark domain is provided', async () => { | |||
| await expect(account.getAddressFromStarkName('invalid-domain', namingAddress)).rejects.toThrow( | |||
There was a problem hiding this comment.
Suggested change
| await expect(account.getAddressFromStarkName('invalid-domain', namingAddress)).rejects.toThrow( | |
| await expect(account.getAddressFromStarkName('InvalidDomain', namingAddress)).rejects.toThrow( |
Since the opening ternary from getAddressFromStarkName appends .stark to the name input invalid-domain.stark ends up matching the isStarkDomain regex and the test fails.
There was a problem hiding this comment.
Yep my bad, added a forbidden character _ so it works
penovicp
approved these changes
Jan 28, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jan 29, 2025
## [6.21.2](v6.21.1...v6.21.2) (2025-01-29) ### Bug Fixes * add starkid improvements ([#1301](#1301)) ([51702db](51702db))
|
🎉 This PR is included in version 6.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Resolution
Argent ran into a problem using
useDecodedwhen decoding the domainGrug.stark, this should have been passed asgrug.starkbut they didn't have theisStarkDomainto do so easily.Usage related changes
I'm addding two things to help wallet and devs in general:
isStarkDomainto permit manual verificationgetAddressFromStarkNameto make the function detect this kind of name errors in the future