Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] add stashNotes #192

Merged
merged 4 commits into from
Feb 17, 2024
Merged

[plugin] add stashNotes #192

merged 4 commits into from
Feb 17, 2024

Conversation

QxxxGit
Copy link
Contributor

@QxxxGit QxxxGit commented Oct 31, 2023

No description provided.

@scruffynerf scruffynerf self-assigned this Oct 31, 2023
@scruffynerf
Copy link
Contributor

Not working for me, no icon at all in corner when expected, didn't matter what browser, no other plugins/etc. neither on latest Devel or v23.1

@scruffynerf scruffynerf self-requested a review November 9, 2023 03:56
Copy link
Contributor

@scruffynerf scruffynerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, however it needs the UI work by @WithoutPants in https://github.com/WithoutPants/stash/tree/ui-plugins-4

so on hold from approval until that code merged.

@DogmaDragon
Copy link
Contributor

I'm having the issue of the button not always loading. Sometimes I need to refresh the page several times for it to show. I assume it has to do with the order stuff is loaded, but that needs to be looked at.

@Tetrax-10
Copy link
Collaborator

We appreciate your contribution. Please note that CommunityScripts now adheres to strict formatting guidelines. Kindly refer to the Contributing guide for instructions.

@Tetrax-10
Copy link
Collaborator

Looks good 👍.

@Tetrax-10 Tetrax-10 changed the title Added Stash Notes plugin [plugin] add stashNotes Feb 17, 2024
@Tetrax-10 Tetrax-10 merged commit 983b28b into stashapp:main Feb 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants