Skip to content

Commit

Permalink
Resolve review comments
Browse files Browse the repository at this point in the history
Signed-off-by: Md. Ishtiaq Islam <[email protected]>
  • Loading branch information
ishtiaqhimel committed Jan 19, 2024
1 parent 4c06ed8 commit 33e5061
Showing 1 changed file with 8 additions and 8 deletions.
16 changes: 8 additions & 8 deletions pkg/util/addon.go
Original file line number Diff line number Diff line change
Expand Up @@ -77,22 +77,22 @@ func getTaskParams(task v1beta1.TaskRef) []appcat.Param {
}

func upsertParams(oldParams, newParams []appcat.Param) []appcat.Param {
newParamsMap := make(map[string]appcat.Param)
paramMap := make(map[string]appcat.Param)

for _, newParam := range newParams {
newParamsMap[newParam.Name] = newParam
paramMap[newParam.Name] = newParam
}

for _, oldParam := range oldParams {
if _, found := newParamsMap[oldParam.Name]; !found {
newParamsMap[oldParam.Name] = oldParam
if _, found := paramMap[oldParam.Name]; !found {
paramMap[oldParam.Name] = oldParam
}
}

var resultParams []appcat.Param
for _, param := range newParamsMap {
resultParams = append(resultParams, param)
var updatedParams []appcat.Param
for _, param := range paramMap {
updatedParams = append(updatedParams, param)
}

return resultParams
return updatedParams
}

0 comments on commit 33e5061

Please sign in to comment.