Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Field action modals #11129

Merged
merged 77 commits into from
Nov 20, 2024
Merged

[5.x] Field action modals #11129

merged 77 commits into from
Nov 20, 2024

Commits on Apr 15, 2024

  1. WIP

    @jacksleight
    jacksleight committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    1cc2d38 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Merge branch '5.x' into feature/field-actions

    @jacksleight
    jacksleight committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    1e9867c View commit details
    Browse the repository at this point in the history

  2. WIP

    @jacksleight
    jacksleight committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    d4acda0 View commit details
    Browse the repository at this point in the history

  3. WIP

    @jacksleight
    jacksleight committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    ab1c934 View commit details
    Browse the repository at this point in the history

  4. WIP

    @jacksleight
    jacksleight committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    42e5d49 View commit details
    Browse the repository at this point in the history

  5. WIP

    @jacksleight
    jacksleight committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    c1d3fcb View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. WIP

    @jacksleight
    jacksleight committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    a99d386 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. Merge branch '5.x' into feature/field-actions

    @jacksleight
    jacksleight committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9be3506 View commit details
    Browse the repository at this point in the history

  2. Visibilty callback

    @jacksleight
    jacksleight committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    97bf8e4 View commit details
    Browse the repository at this point in the history

  3. Set payloads

    @jacksleight
    jacksleight committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    bbcd085 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. WIP

    @jacksleight
    jacksleight committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    330cd53 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. WIP

    @jacksleight
    jacksleight committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2d61913 View commit details
    Browse the repository at this point in the history

  2. Merge branch '5.x' into feature/field-actions

    @jacksleight
    jacksleight authored Sep 20, 2024
    Configuration menu
    Copy the full SHA
    bc84bdd View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. Tweak payload keys

    @jacksleight
    jacksleight committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    a448f97 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'feature/field-actions' of github.com:jacksleight/statam… 

    …ic-cms into feature/field-actions
    @jacksleight
    jacksleight committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    cb53588 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Naming tweaks

    @jacksleight
    jacksleight committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5002d37 View commit details
    Browse the repository at this point in the history

  2. Naming tweaks, round two

    @jacksleight
    jacksleight committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    eed8334 View commit details
    Browse the repository at this point in the history

  3. Ensure dropdown buttons dont submit forms

    @jacksleight
    jacksleight committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    d7d3fe4 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Option to resolve icons using callback

    @jacksleight
    jacksleight committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d081de7 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Merge branch '5.x' into feature/field-actions

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    8c7c595 View commit details
    Browse the repository at this point in the history

  2. marking an action as quick without an icon breaks. this defaults it t… 

    …o a placeholder
    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    90462b2 View commit details
    Browse the repository at this point in the history

  3. noticed that there is a white background. when displayed on non-white… 

    … it's wonky.
    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    6ac8c38 View commit details
    Browse the repository at this point in the history

  4. rename

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    4fd3dc7 View commit details
    Browse the repository at this point in the history

  5. organize/rename

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    2ba3164 View commit details
    Browse the repository at this point in the history

  6. dont need the custom components only being used in one place

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    e49eeac View commit details
    Browse the repository at this point in the history

  7. bracies

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    5e49e49 View commit details
    Browse the repository at this point in the history

  8. import dropdown actions as components. no need to be global.

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    3232403 View commit details
    Browse the repository at this point in the history

  9. pass the payload along with the filter function

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    af782a0 View commit details
    Browse the repository at this point in the history

  10. fix error

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    020bdc1 View commit details
    Browse the repository at this point in the history

  11. more of 90462b2

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1f65ba7 View commit details
    Browse the repository at this point in the history

  12. more calling field actions field actions

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    546f2b7 View commit details
    Browse the repository at this point in the history

  13. nitpick

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    704da52 View commit details
    Browse the repository at this point in the history

  14. merge internal and custom actions

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    06c4f00 View commit details
    Browse the repository at this point in the history

  15. self closing

    @jasonvarga
    jasonvarga committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    0a47981 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2024

  1. Refactor to class ... 

    - Move logic into a dedicated FieldAction class.
- Avoids passing around functions as props and needing to define field action related functions in mixins
- The quick property can now also be a function.
- The run, quick, visible, and icon methods all get the same payload.
    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    e16e990 View commit details
    Browse the repository at this point in the history

  2. change to title prop

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    dc8651d View commit details
    Browse the repository at this point in the history

  3. nitpick

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ae740cf View commit details
    Browse the repository at this point in the history

  4. action.display isnt a thing

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    acacecf View commit details
    Browse the repository at this point in the history

  5. We never care about non-visible actions

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    fbde34f View commit details
    Browse the repository at this point in the history

  6. nitpick

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7f59960 View commit details
    Browse the repository at this point in the history

  7. oops from dc8651d

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    89466b6 View commit details
    Browse the repository at this point in the history

  8. Add bits from #10833 

    Co-authored-by: Jack Sleight <[email protected]>
    @jasonvarga @jacksleight
    jasonvarga and jacksleight committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    089a76f View commit details
    Browse the repository at this point in the history

  9. move modal out of $fieldActions and into run method

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cca2c56 View commit details
    Browse the repository at this point in the history

  10. pass missing confirmed bool

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    40b5b06 View commit details
    Browse the repository at this point in the history

  11. dont worry about dirty stuff

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    36045b6 View commit details
    Browse the repository at this point in the history

  12. extract variable

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    be70422 View commit details
    Browse the repository at this point in the history

  13. nitpick

    @jasonvarga
    jasonvarga committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f2c899b View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2024

  1. always use the same component

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    7668295 View commit details
    Browse the repository at this point in the history

  2. body text has a default when both are missing

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f869093 View commit details
    Browse the repository at this point in the history

  3. always close the modal on confirm

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3ff8ae4 View commit details
    Browse the repository at this point in the history

  4. if no fields, confirming will close

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    72114b2 View commit details
    Browse the repository at this point in the history

  5. show field actions in bard/replicator subfields

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3be1965 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'feature/field-actions' into field-action-modals

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    3f84785 View commit details
    Browse the repository at this point in the history

  7. actions can provide a confirm object to get a modal instead of doing … 

    …it in run
    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    21064d2 View commit details
    Browse the repository at this point in the history

  8. loading state is handled automatically if run returns a promise

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    733fbbb View commit details
    Browse the repository at this point in the history

  9. handle reject too

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    bd39989 View commit details
    Browse the repository at this point in the history

  10. allow confirm: true

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    d6d3c77 View commit details
    Browse the repository at this point in the history

  11. words

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    f1aca3e View commit details
    Browse the repository at this point in the history

  12. nitpick

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    cc3015e View commit details
    Browse the repository at this point in the history

  13. nitpick

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9b00510 View commit details
    Browse the repository at this point in the history

  14. initial body text better. if there are fields dont set a default

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    c00a1ff View commit details
    Browse the repository at this point in the history

  15. modal title defaults to the action title

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    e3e16f2 View commit details
    Browse the repository at this point in the history

  16. do better

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    9a01bbf View commit details
    Browse the repository at this point in the history

  17. call it text

    @jasonvarga
    jasonvarga committed Nov 19, 2024
    Configuration menu
    Copy the full SHA
    61bf410 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. handle situations when the field reference doesnt exist - like lazy l… 

    …oaded meta. and make consistent in replicator field.
    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    9ab940d View commit details
    Browse the repository at this point in the history

  2. avoid rendering components if we're just going to hide it with css.

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    fed5bfe View commit details
    Browse the repository at this point in the history

  3. specific

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cff367f View commit details
    Browse the repository at this point in the history

  4. Merge branch 'feature/field-actions' into field-action-modals

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4333750 View commit details
    Browse the repository at this point in the history

  5. make reactive again by putting it back into a computed. oopsie i brok… 

    …e it in 9ab940d
    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    f922f2d View commit details
    Browse the repository at this point in the history

  6. dont bother rendering actions if they arent going to be visible

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2e7f147 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'feature/field-actions' into field-action-modals

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    6cc29f4 View commit details
    Browse the repository at this point in the history

  8. fix modals in modals (in modals (in modals (in modals...)))

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cc98155 View commit details
    Browse the repository at this point in the history

  9. add isReadOnly to payload

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    4228001 View commit details
    Browse the repository at this point in the history

  10. actions arent shown by default on read only fields but can be opted in

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    0973f48 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'feature/field-actions' into field-action-modals

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    cb037a3 View commit details
    Browse the repository at this point in the history

  12. nitpick

    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    1e1409e View commit details
    Browse the repository at this point in the history

  13. Merge branch '5.x' into field-action-modals 

    # Conflicts:
#	resources/js/components/field-actions/FieldAction.js
    @jasonvarga
    jasonvarga committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    2e1633d View commit details
    Browse the repository at this point in the history