Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ParentField.php #50

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update ParentField.php #50

wants to merge 1 commit into from

Conversation

Sindoweb
Copy link
Contributor

@Sindoweb Sindoweb commented Nov 4, 2024

Description

Changed parent to parent_id because this gave errors when saving an edit of a page.

Reason for this change

I figured I could change this since all the references in the Concerns are to parent_id.
It solved my issue, but I'm not sure if this change is correct.

Changed parent to parent_id because this gave errors when saving an edit of a page.
@sten
Copy link
Contributor

sten commented Nov 8, 2024

@Sindoweb thanks for the PR. That would indeed have cleaner to use parent_id.

The problem is that by changing the constant, it will be breaking for all upgrades. So the options are:

  1. try to make both parent & parent_id work
  2. release a major version

I will contemplate on this choice a bit more. If you have ideas, shoot! ;-)

@Sindoweb
Copy link
Contributor Author

Sindoweb commented Nov 8, 2024

@sten

  1. try to make both parent & parent_id work

Maybe a check if parent_id is not empty (and use that if it isn't).
Otherwise use parent.

I'll play around with this to see what gives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants