Update dapla-toolbelt to use 'ssb-pypitemplate' #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions (we can use **kwargs)
bjornandre
reviewed
Jan 16, 2024
bjornandre
reviewed
Jan 16, 2024
mallport
force-pushed
the
update-ssb-pypitemplate
branch
from
d7af9ef to
c2c9828
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include typing, and all the tools and goodies that come with
ssb-pypitemplateThe vast, vast majority of the changes are formatting changes from Ruff, and type hints being added. The only functional change is changing to use Google's built-in "refresh_handler" to tackle credential refreshes on Dapla Lab. The change can be found here. Previously, we were hard-overriding the "refresh()" method, whic made MyPy extremely angry.