-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statR version 2.4.0 #60
Conversation
Thomas-Caspar-Fischer
commented
Jan 26, 2024
- redesigned user configurations
- further modularized the functions used to generate worksheets
- revised vignette on creating excel files & regenerated pkgdown
Feature new colors
Merge branch 'dev' of https://github.com/statistikZH/statR into dev # Conflicts: # .Rbuildignore # DESCRIPTION # docs/articles/Visualisierungen.html # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-10-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-11-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-12-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-13-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-5-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-6-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-7-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-8-1.png # docs/articles/Visualisierungen_files/figure-html/unnamed-chunk-9-1.png # docs/news/index.html # docs/pkgdown.yml # docs/reference/datasetsXLSX.html # docs/reference/display.statcol.all-1.png # docs/reference/display.statcol.all.html # docs/reference/motor_trend_car_road_tests.xlsx # vignettes/Visualisierungen.Rmd
… unexported helper functions).
Version 2.4.0 * redesigned user configurations * further modularized the functions used to generate worksheets * revised vignette on creating excel files & regenerated pkgdown Co-authored-by: tknecht <[email protected]>
…rkaround for temporary installation (forgoes write to configstore during temp install); (0e, 0w, 0n). (#61)
The issue related to staged installation has been solved on RStudio Server and Windows systems. The config store file is allocated, and the default configuration is being loaded correctly. The checks are still failing, though. Apparently the default config file is not being found during final installation in the GitHub action checks, and I'm not sure why. |
Merge branch 'dev' of https://github.com/statistikZH/statR into dev # Conflicts: # R/user_config.R # inst/extdata/config/default.yaml
…t to NA; updated vignette to account for changed use of user configurations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolut starke Arbeit @Thomas-Caspar-Fischer!
Finde die Doku sehr, sehr gut aufgebaut und zugänglich. Nur kleine Typos/Grammatik-Hickups gefunden.
Falls es für dich funktioniert, gerne ignorieren:
Ich kann leider weder die Vignette noch die Pages builden.
> devtools::build_site() Error: ! in callr subprocess. Caused by error in
purrr::map(topics, build_reference_topic, pkg = pkg, lazy = lazy, …: ! In index: 1. ℹ See
$stdout for standard output. Type .Last.error to see the more details.
Das Problem besteht wohl schon eine Weile. Problematisch, weil die pkgdown-Seite den Stand von Version 2.2 reflektiert.
Es besteht noch ein weiteres Problem. Das pkgdown template wird vermutlich nicht verwendet (Fehlermeldung im parenttrace). Ich schau mir das noch an. Danke für das Review. Die sprachlichen Änderungen habe ich übernommen und das Problem mit pkgdown sollte kurzfristig gelöst sein. Längerfristig müsste man allenfalls die Dateien im pkgdown/templates Verzeichnis überarbeiten. |