Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(go): increase timeouts to make tests less fragile in GH workflows #32

Merged
merged 2 commits into from
Jan 11, 2023
Merged

test(go): increase timeouts to make tests less fragile in GH workflows #32

merged 2 commits into from
Jan 11, 2023

Conversation

padlar
Copy link
Contributor

@padlar padlar commented Jan 11, 2023 •
edited
Loading

Closes #27.

Signed-off-by: Sunil Shivanand [email protected]

@padlar padlar requested a review from a team as a code owner January 11, 2023 13:29
erikgb
erikgb reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@erikgb erikgb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but maybe adjust the title? Suggestion:
test(go): increase timeouts to make tests less fragile in GH workflows

And maybe this closes #27?

@padlar padlar changed the title chore(test): increase the timeout if the tests pass in github test(go): increase timeouts to make tests less fragile in GH workflows Jan 11, 2023
@padlar padlar requested a review from erikgb January 11, 2023 14:26
erikgb
erikgb approved these changes Jan 11, 2023
View reviewed changes
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we assume it closes #27? We can just reopen it if it doesn't.

@padlar
Copy link
Contributor Author

padlar commented Jan 11, 2023

Updated

@padlar padlar merged commit d3f3d9b into statnett:main Jan 11, 2023
@padlar padlar deleted the increase-timeout-test branch January 11, 2023 14:32
@erikgb erikgb mentioned this pull request Jan 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikgb erikgb erikgb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go tests seem flaky
2 participants
@padlar @erikgb