-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(e2e): debug e2e-tests, don't merge! #82
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikgb
previously approved these changes
Jan 17, 2023
bendikp
force-pushed
the
add-collector-for-scan-job
branch
from
January 17, 2023 09:05
e2f5814
to
9e2c2ec
Compare
erikgb
reviewed
Jan 17, 2023
bendikp
force-pushed
the
add-collector-for-scan-job
branch
from
January 17, 2023 19:44
9e2c2ec
to
4e04bb4
Compare
Is this PR still in draft? Or ready for review? |
Still a draft, I didn't manage to make this a draft PR again. I think we have enough debug info from this PR in order to proceed down the rabbit hole, so I guess there are no need to merge this PR. Just keep it as a "debug PR". |
bendikp
changed the title
test(e2e): add collector for flacky scan job
test(e2e): debug e2e-tests, don't merge!
Jan 18, 2023
erikgb
force-pushed
the
add-collector-for-scan-job
branch
from
January 19, 2023 07:42
80540ed
to
393bc28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a collector on the flaky e2e-test. Related #19