Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): debug e2e-tests, don't merge! #82

Closed
wants to merge 8 commits into from

Conversation

bendikp
Copy link
Member

@bendikp bendikp commented Jan 17, 2023

This PR add a collector on the flaky e2e-test. Related #19

erikgb
erikgb previously approved these changes Jan 17, 2023
@bendikp bendikp force-pushed the add-collector-for-scan-job branch from e2f5814 to 9e2c2ec Compare January 17, 2023 09:05
@bendikp bendikp marked this pull request as ready for review January 17, 2023 09:07
@bendikp bendikp requested a review from a team as a code owner January 17, 2023 09:07
@bendikp bendikp force-pushed the add-collector-for-scan-job branch from 9e2c2ec to 4e04bb4 Compare January 17, 2023 19:44
@erikgb
Copy link
Member

erikgb commented Jan 17, 2023

Is this PR still in draft? Or ready for review?

@bendikp
Copy link
Member Author

bendikp commented Jan 18, 2023

Still a draft, I didn't manage to make this a draft PR again. I think we have enough debug info from this PR in order to proceed down the rabbit hole, so I guess there are no need to merge this PR. Just keep it as a "debug PR".

@bendikp bendikp changed the title test(e2e): add collector for flacky scan job test(e2e): debug e2e-tests, don't merge! Jan 18, 2023
@bendikp bendikp marked this pull request as draft January 18, 2023 06:45
@erikgb erikgb force-pushed the add-collector-for-scan-job branch from 80540ed to 393bc28 Compare January 19, 2023 07:42
@bendikp bendikp closed this Jan 23, 2023
@erikgb erikgb deleted the add-collector-for-scan-job branch September 3, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants