feat: add opt-in to terminate non-empty topics matching props #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sverrehu
reviewed
Oct 27, 2024
src/main/java/io/statnett/k3a/topicterminator/strategy/TopicNotMatchingProps.java
Outdated
Show resolved
Hide resolved
erikgb
force-pushed
the
non-empty-matching-props
branch
from
88f0bb6 to
8004ba6
Compare
sverrehu
reviewed
Oct 28, 2024
src/main/java/io/statnett/k3a/topicterminator/TopicTerminator.java
Outdated
Show resolved
Hide resolved
src/main/java/io/statnett/k3a/topicterminator/TopicTerminator.java
Outdated
Show resolved
Hide resolved
erikgb
force-pushed
the
non-empty-matching-props
branch
from
8004ba6 to
75e15ae
Compare
sverrehu
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to terminate non-empty compacting, otherwise unused topics in our clusters. The PR adds an option to delete topics with data if the topic configuration matches the supplied properties.